Fokko commented on code in PR #2173:
URL: https://github.com/apache/iceberg-python/pull/2173#discussion_r2209233326
##########
pyiceberg/utils/schema_conversion.py:
##########
@@ -69,8 +69,10 @@
LOGICAL_FIELD_TYPE_MAPPING: Dict[Tuple[str, str], PrimitiveType] = {
("date", "int"): DateType(),
("time-micros", "long"): TimeType(),
+ ("timestamp-millis", "int"): TimestampType(),
Review Comment:
Thanks for working on this @matthias-Q, however, I think this is not correct.
Do we know if this is safe to do so? `TimestampType` implicitly assumes that
the value is represented in `micros`, and not `millis`. Prior to Iceberg V3
everything was implicitly in micros, I would at least expect some logic to
convert the actual value from millis to micros (since we don't have a millis
Type in Iceberg).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
