SanjayMarreddi commented on code in PR #13348:
URL: https://github.com/apache/iceberg/pull/13348#discussion_r2163486544
##########
aws/src/main/java/org/apache/iceberg/aws/s3/AnalyticsAcceleratorInputStreamWrapper.java:
##########
@@ -19,31 +19,47 @@
package org.apache.iceberg.aws.s3;
import java.io.IOException;
+import org.apache.iceberg.io.FileIOMetricsContext;
import org.apache.iceberg.io.SeekableInputStream;
+import org.apache.iceberg.metrics.Counter;
+import org.apache.iceberg.metrics.MetricsContext;
import software.amazon.s3.analyticsaccelerator.S3SeekableInputStream;
/** A wrapper to convert {@link S3SeekableInputStream} to Iceberg {@link
SeekableInputStream} */
class AnalyticsAcceleratorInputStreamWrapper extends SeekableInputStream {
private final S3SeekableInputStream delegate;
+ private final Counter readBytes;
+ private final Counter readOperations;
AnalyticsAcceleratorInputStreamWrapper(S3SeekableInputStream stream) {
- this.delegate = stream;
+ this(stream, MetricsContext.nullMetrics());
}
- @Override
- public int read() throws IOException {
- return this.delegate.read();
+ AnalyticsAcceleratorInputStreamWrapper(S3SeekableInputStream stream,
MetricsContext metrics) {
+ this.delegate = stream;
+ this.readBytes = metrics.counter(FileIOMetricsContext.READ_BYTES,
MetricsContext.Unit.BYTES);
+ this.readOperations =
metrics.counter(FileIOMetricsContext.READ_OPERATIONS);
}
@Override
- public int read(byte[] b) throws IOException {
- return this.delegate.read(b, 0, b.length);
+ public int read() throws IOException {
+ int nextByteValue = this.delegate.read();
+ if (nextByteValue != -1) {
+ readBytes.increment();
+ }
+ readOperations.increment();
+ return nextByteValue;
}
@Override
public int read(byte[] b, int off, int len) throws IOException {
- return this.delegate.read(b, off, len);
+ int bytesRead = this.delegate.read(b, off, len);
+ if (bytesRead > 0) {
Review Comment:
Its because the `bytesRead` can be `-1` also. ( If no byte is available
because the stream is at end of file )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
