SanjayMarreddi commented on code in PR #13348:
URL: https://github.com/apache/iceberg/pull/13348#discussion_r2157285379
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java:
##########
@@ -234,7 +239,12 @@ public void testCrossRegionAccessEnabled() throws
Exception {
@Test
public void testNewInputStreamWithCrossRegionAccessPoint() throws Exception {
requireAccessPointSupport();
-
clientFactory.initialize(ImmutableMap.of(S3FileIOProperties.USE_ARN_REGION_ENABLED,
"true"));
+ Map<String, String> properties =
+ ImmutableMap.of(S3FileIOProperties.USE_ARN_REGION_ENABLED, "true");
+ skipIfAnalyticsAcceleratorEnabled(
+ new S3FileIOProperties(properties),
+ "S3 Async Clients needed for Analytics Accelerator Library does not
support Cross Region Access Points");
Review Comment:
We could do it but basically this feature gap comes from the Async client
configuration done on the S3FileIO side. So in the upcoming PRs, once we update
the corresponding s3 client mutations ( `applyServiceConfigurations` ), we
should be in a position to stop skipping tests.
PS: Out of the 2 async clients, Java Async client supports this for sure,
CRT async client might have limited support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
