SanjayMarreddi commented on code in PR #13348:
URL: https://github.com/apache/iceberg/pull/13348#discussion_r2157377866
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3MultipartUpload.java:
##########
@@ -59,12 +61,13 @@ public class TestS3MultipartUpload {
@BeforeAll
public static void beforeClass() {
s3 = AwsClientFactories.defaultFactory().s3();
+ s3Async = AwsClientFactories.defaultFactory().s3Async();
Review Comment:
Thanks for raising this point. It made me rethink that we don't actually
have to pass the `asyncClient` if we want to just use the
`defaultFactory.s3Async()`. Because in the recent refactoring of S3FileIO where
`PrefixedS3Client` is used in the creation of `S3InputFile` files, it by
default has the implementation of async client as shown
[here](https://github.com/apache/iceberg/blob/main/aws/src/main/java/org/apache/iceberg/aws/s3/PrefixedS3Client.java#L66).
So we could remove explicitly passing async clients in some tests.
I've updated it now and retained passing of Async clients in tests only when
there is a need for specific async clients, such as: `Minio` based or flaky
versions of clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
