SanjayMarreddi commented on code in PR #13348:
URL: https://github.com/apache/iceberg/pull/13348#discussion_r2157163336
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java:
##########
@@ -484,15 +494,19 @@ public void testServerSideCustomEncryption() throws
Exception {
String md5 =
new String(encoder.encode(digest.digest(secretKey.getEncoded())),
StandardCharsets.UTF_8);
- S3FileIO s3FileIO = new S3FileIO(clientFactory::s3);
- s3FileIO.initialize(
+ S3FileIO s3FileIO = new S3FileIO(clientFactory::s3,
clientFactory::s3Async);
+ Map<String, String> properties =
ImmutableMap.of(
S3FileIOProperties.SSE_TYPE,
S3FileIOProperties.SSE_TYPE_CUSTOM,
S3FileIOProperties.SSE_KEY,
encodedKey,
S3FileIOProperties.SSE_MD5,
- md5));
+ md5);
+ skipIfAnalyticsAcceleratorEnabled(
+ new S3FileIOProperties(properties),
+ "Analytics Accelerator Library does not support Server Side Custom
Encryption");
Review Comment:
It's just to avoid defining `S3FileIOProperties` multiple times/update them
again. In the current code, we have kept it here because the `properties` map
depends on the creation of the variables `encodedKey ` and `md5`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
