kevinjqliu commented on code in PR #2125:
URL: https://github.com/apache/iceberg-python/pull/2125#discussion_r2159208827
##########
.github/workflows/python-ci.yml:
##########
@@ -84,3 +84,21 @@ jobs:
- name: Show debug logs
if: ${{ failure() }}
run: docker compose -f dev/docker-compose.yml logs
+
+ object-store-integration-test:
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ python: ['3.9', '3.10', '3.11', '3.12']
+
+ steps:
+ - uses: actions/checkout@v4
+ - name: Install system dependencies
+ run: sudo apt-get update && sudo apt-get install -y libkrb5-dev # for
kerberos
+ - name: Install
+ run: make install
+ - name: Run object store integration tests
+ run: make test-coverage-object-store-integration
+ - name: Show debug logs
+ if: ${{ failure() }}
+ run: docker compose -f dev/docker-compose.yml logs
Review Comment:
good one
##########
pyproject.toml:
##########
@@ -75,6 +75,7 @@ boto3 = { version = ">=1.24.59", optional = true }
s3fs = { version = ">=2023.1.0", optional = true }
adlfs = { version = ">=2023.1.0", optional = true }
gcsfs = { version = ">=2023.1.0", optional = true }
+google-api-core = { version = "^2.0", optional = true }
Review Comment:
looks like #2127 fixed the underlying issue so we dont even need to do this
anymore. nice!
##########
Makefile:
##########
@@ -62,44 +58,51 @@ test-integration-setup: # Prepare the environment for
integration
docker compose -f dev/docker-compose-integration.yml cp
./dev/provision.py spark-iceberg:/opt/spark/provision.py
docker compose -f dev/docker-compose-integration.yml exec -T
spark-iceberg ipython ./provision.py
-test-integration-exec: # Execute integration tests, can add arguments with
PYTEST_ARGS="-vv"
+test-integration-exec: # Execute integration tests, can add arguments with
PYTEST_ARGS="-vv"
Review Comment:
same, so i just linted manually 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
