Fokko commented on code in PR #2125:
URL: https://github.com/apache/iceberg-python/pull/2125#discussion_r2158150237
##########
.github/workflows/python-ci.yml:
##########
@@ -84,3 +84,21 @@ jobs:
- name: Show debug logs
if: ${{ failure() }}
run: docker compose -f dev/docker-compose.yml logs
+
+ object-store-integration-test:
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ python: ['3.9', '3.10', '3.11', '3.12']
+
+ steps:
+ - uses: actions/checkout@v4
+ - name: Install system dependencies
+ run: sudo apt-get update && sudo apt-get install -y libkrb5-dev # for
kerberos
+ - name: Install
+ run: make install
+ - name: Run object store integration tests
+ run: make test-coverage-object-store-integration
Review Comment:
A couple of observations:
- Maybe run each of the tests in a separate step? Instead of running
`test-coverage-object-store-integration`, it would be nice to have separate
steps for `test-s3`, `test-adls`, etc.
- We could also run these tests just after the normal integration tests to
save some resources. This avoids installing all the dependencies twice, and the
tests share some containers.
- We run this with coverage, but we don't report the coverage, nor fail on
it since we don't run the `poetry run coverage combine .coverage.unit
.coverage.integration` etc steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
