Fokko commented on code in PR #2125:
URL: https://github.com/apache/iceberg-python/pull/2125#discussion_r2158172725
##########
Makefile:
##########
@@ -62,44 +58,51 @@ test-integration-setup: # Prepare the environment for
integration
docker compose -f dev/docker-compose-integration.yml cp
./dev/provision.py spark-iceberg:/opt/spark/provision.py
docker compose -f dev/docker-compose-integration.yml exec -T
spark-iceberg ipython ./provision.py
-test-integration-exec: # Execute integration tests, can add arguments with
PYTEST_ARGS="-vv"
+test-integration-exec: # Execute integration tests, can add arguments with
PYTEST_ARGS="-vv"
poetry run pytest tests/ -v -m integration ${PYTEST_ARGS}
test-integration-rebuild:
docker compose -f dev/docker-compose-integration.yml kill
docker compose -f dev/docker-compose-integration.yml rm -f
docker compose -f dev/docker-compose-integration.yml build --no-cache
-test-adls: ## Run tests marked with adls, can add arguments with
PYTEST_ARGS="-vv"
+test-object-store-integration: test-s3 test-adls test-gcs # Run object stores
integration tests, can add arguments with PYTEST_ARGS="-vv"
+
+test-s3: # Run tests marked with s3, can add arguments with PYTEST_ARGS="-vv"
+ sh ./dev/run-minio.sh
+ poetry run pytest tests/ -m s3 ${PYTEST_ARGS}
+
+test-adls: # Run tests marked with adls, can add arguments with
PYTEST_ARGS="-vv"
sh ./dev/run-azurite.sh
poetry run pytest tests/ -m adls ${PYTEST_ARGS}
-test-gcs: ## Run tests marked with gcs, can add arguments with
PYTEST_ARGS="-vv"
+test-gcs: # Run tests marked with gcs, can add arguments with PYTEST_ARGS="-vv"
sh ./dev/run-gcs-server.sh
- poetry run pytest tests/ -m gcs ${PYTEST_ARGS}
+ poetry run pytest tests/ -m gcs ${PYTEST_ARGS}
test-coverage-unit: # Run test with coverage for unit tests, can add arguments
with PYTEST_ARGS="-vv"
poetry run coverage run --source=pyiceberg/ --data-file=.coverage.unit
-m pytest tests/ -v -m "(unmarked or parametrize) and not integration"
${PYTEST_ARGS}
-test-coverage-integration: # Run test with coverage for integration tests, can
add arguments with PYTEST_ARGS="-vv"
- docker compose -f dev/docker-compose-integration.yml kill
- docker compose -f dev/docker-compose-integration.yml rm -f
- docker compose -f dev/docker-compose-integration.yml up -d
+test-coverage-integration: test-integration-setup
test-object-store-integration # Run test with coverage for integration tests,
can add arguments with PYTEST_ARGS="-vv"
+ poetry run coverage run --source=pyiceberg/
--data-file=.coverage.integration -m pytest tests/ -v -m integration
${PYTEST_ARGS}
+
+test-coverage-object-store-integration: # Run test with coverage for object
stores integration tests, can add arguments with PYTEST_ARGS="-vv"
+ sh ./dev/run-minio.sh
+ poetry run coverage run --source=pyiceberg/
--data-file=.coverage.integration -m pytest tests/ -m s3 ${PYTEST_ARGS}
Review Comment:
We now have a distinction between with and without coverage. I think we
always install the coverage plugin, so maybe we could just always report
coverage? This would almost cut the size of the `Makefile` in half. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
