kevinjqliu commented on code in PR #2125:
URL: https://github.com/apache/iceberg-python/pull/2125#discussion_r2157794828
##########
Makefile:
##########
@@ -34,25 +34,21 @@ install-poetry: ## Ensure Poetry is installed and the
correct version is being
fi \
fi
-install-dependencies: ## Install dependencies including dev, docs, and all
extras
+install-dependencies: # Install dependencies including dev, docs, and all
extras
poetry install --all-extras
-install: | install-poetry install-dependencies
+install: | install-poetry install-dependencies # Install poetry and all
dependencies
-check-license: ## Check license headers
+check-license: # Check license headers
./dev/check-license
-lint: ## lint
+lint: # lint
poetry run pre-commit run --all-files
-test: ## Run all unit tests, can add arguments with PYTEST_ARGS="-vv"
+test: # Run all unit tests, can add arguments with PYTEST_ARGS="-vv"
poetry run pytest tests/ -m "(unmarked or parametrize) and not
integration" ${PYTEST_ARGS}
-test-s3: # Run tests marked with s3, can add arguments with PYTEST_ARGS="-vv"
- sh ./dev/run-minio.sh
- poetry run pytest tests/ -m s3 ${PYTEST_ARGS}
Review Comment:
refactor: move lower and closer to test-adls and test-gcs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
