elphastori commented on code in PR #13129:
URL: https://github.com/apache/iceberg/pull/13129#discussion_r2105893412
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -565,13 +568,16 @@ public List<Namespace> listNamespaces(SessionContext
context, Namespace namespac
}
ImmutableList.Builder<Namespace> namespaces = ImmutableList.builder();
- String pageToken = "";
+ String pageToken = null;
if (pageSize != null) {
queryParams.put("pageSize", String.valueOf(pageSize));
}
do {
- queryParams.put("pageToken", pageToken);
+ if (pageToken != null) {
+ queryParams.put("pageToken", pageToken);
+ }
+
Review Comment:
`pageToken` needs to be set inside the loop because it must be updated with
each request, unlike `pageSize`, which remains constant.
Here’s an example sequence of requests from the unit tests:
1. http://localhost:8181/v1/namespaces/default/tables?pageSize=10
2.
http://localhost:8181/v1/namespaces/default/tables?pageSize=10&pageToken=10
3.
http://localhost:8181/v1/namespaces/default/tables?pageSize=10&pageToken=20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
