ajantha-bhat commented on code in PR #13123:
URL: https://github.com/apache/iceberg/pull/13123#discussion_r2103970632
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -295,6 +295,13 @@ protected void validateNewDeleteFile(DeleteFile file) {
formatVersion(),
file.location());
break;
+ case 4:
Review Comment:
why not combine the case 3 and 4 (fall through) as it is identical?
##########
api/src/test/java/org/apache/iceberg/TestHelpers.java:
##########
@@ -54,7 +54,7 @@ public class TestHelpers {
private TestHelpers() {}
- public static final int MAX_FORMAT_VERSION = 3;
+ public static final int MAX_FORMAT_VERSION = 4;
Review Comment:
Since v4 spec is not there, I am not sure we should enable this in code at
the moment.
What if user configures v4, what does it actually mean a v4 table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
