RussellSpitzer commented on code in PR #13123:
URL: https://github.com/apache/iceberg/pull/13123#discussion_r2102786877
##########
core/src/test/java/org/apache/iceberg/DeleteFileIndexTestBase.java:
##########
@@ -50,7 +50,7 @@ public abstract class DeleteFileIndexTestBase<
@Parameters(name = "formatVersion = {0}")
public static List<Object> parameters() {
- return Arrays.asList(2, 3);
+ return Arrays.asList(2, 3, 4);
Review Comment:
nit: Maybe we should change this to use the MAX_VERSION or all Versions
parameter with a (not 1) or something
##########
core/src/test/java/org/apache/iceberg/ScanPlanningAndReportingTestBase.java:
##########
@@ -47,7 +47,7 @@ public abstract class ScanPlanningAndReportingTestBase<
@Parameters(name = "formatVersion = {0}")
public static List<Object> parameters() {
- return Arrays.asList(2, 3);
+ return Arrays.asList(2, 3, 4);
Review Comment:
nit: Maybe we should change this to use the MAX_VERSION or all Versions
parameter with a (not 1) or something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
