ajantha-bhat commented on code in PR #13123:
URL: https://github.com/apache/iceberg/pull/13123#discussion_r2106699014


##########
api/src/test/java/org/apache/iceberg/TestHelpers.java:
##########
@@ -54,7 +54,7 @@ public class TestHelpers {
 
   private TestHelpers() {}
 
-  public static final int MAX_FORMAT_VERSION = 3;
+  public static final int MAX_FORMAT_VERSION = 4;

Review Comment:
   Mainly in the `TableMetadata.java`, 
   
   I am not against these changes. I would like to quickly jump on v4 as well. 
Just that it is odd for the users that Iceberg don't have spec v4 documented or 
approved but allows table creation with v4. Maybe better if we get one of the 
v4 feature spec approved and start enabling v4 table creation with that feature 
enabled. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to