ajantha-bhat commented on code in PR #13123:
URL: https://github.com/apache/iceberg/pull/13123#discussion_r2112311313
##########
api/src/test/java/org/apache/iceberg/TestHelpers.java:
##########
@@ -54,7 +54,7 @@ public class TestHelpers {
private TestHelpers() {}
- public static final int MAX_FORMAT_VERSION = 3;
+ public static final int MAX_FORMAT_VERSION = 4;
Review Comment:
I think it’s worth focusing on what’s technically correct rather than solely
relying on what has been done previously. Since we publish nightly builds,
there’s a chance users could start creating v4 tables before any spec is
officially finalized. With the 1.10.0 discussions already underway, this change
could potentially be included in a release without any approved v4 spec.
My suggestion was simply to finalize at least one v4 spec change before
beginning v4 development on the main branch, so that users have a clear
understanding of what features come with enabling v4.
That said, I may be overthinking this or being too cautious 😅. Please feel
free to go with the broader consensus from the community on this PR (other
reviewers opinion).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
