smaheshwar-pltr commented on code in PR #2031:
URL: https://github.com/apache/iceberg-python/pull/2031#discussion_r2101327716
##########
pyiceberg/manifest.py:
##########
@@ -717,6 +717,14 @@ def fetch_manifest_entry(self, io: FileIO,
discard_deleted: bool = True) -> List
if not discard_deleted or entry.status !=
ManifestEntryStatus.DELETED
]
+ def __eq__(self, other: Any) -> bool:
Review Comment:
This file's changes were copied from
https://github.com/apache/iceberg-python/pull/533 and needed because we mirror
Java behaviour
[here](https://github.com/apache/iceberg/blob/1911c94ea605a3d3f10a1994b046f00a5e9fdceb/core/src/main/java/org/apache/iceberg/BaseIncrementalAppendScan.java#L70-L74)
that uses a set. See
https://github.com/apache/iceberg/blob/1911c94ea605a3d3f10a1994b046f00a5e9fdceb/core/src/main/java/org/apache/iceberg/GenericManifestFile.java#L415
also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
