smaheshwar-pltr commented on code in PR #2031:
URL: https://github.com/apache/iceberg-python/pull/2031#discussion_r2101331249
##########
pyiceberg/table/__init__.py:
##########
@@ -1688,102 +1884,246 @@ def _match_deletes_to_data_file(data_entry:
ManifestEntry, positional_delete_ent
return set()
-class DataScan(TableScan):
- def _build_partition_projection(self, spec_id: int) -> BooleanExpression:
- project = inclusive_projection(self.table_metadata.schema(),
self.table_metadata.specs()[spec_id], self.case_sensitive)
- return project(self.row_filter)
+class DataScan(FileBasedScan, TableScan):
Review Comment:
I moved `partition_filters` in this class into the new `ManifestGroup`.
Elaborating on
https://github.com/apache/iceberg-python/pull/2031/files#r2101329296, I think
this is the only user-facing change to a public class that this PR introduces.
(I removed other methods but those are private).
If this is fine, should probably go through the deprecation cycle for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
