smaheshwar-pltr commented on code in PR #2031:
URL: https://github.com/apache/iceberg-python/pull/2031#discussion_r2101326211


##########
dev/provision.py:
##########
@@ -413,3 +413,58 @@
     )
     spark.sql(f"ALTER TABLE {catalog_name}.default.test_empty_scan_ordered_str 
WRITE ORDERED BY id")
     spark.sql(f"INSERT INTO {catalog_name}.default.test_empty_scan_ordered_str 
VALUES 'a', 'c'")
+
+    spark.sql(
+        f"""
+        CREATE OR REPLACE TABLE {catalog_name}.default.test_incremental_read (
+            dt     date,
+            number integer,
+            letter string
+        )
+        USING iceberg
+        TBLPROPERTIES (
+            'format-version'='2'
+        );
+        """
+    )
+
+    spark.sql(
+        f"""
+        INSERT INTO {catalog_name}.default.test_incremental_read
+        VALUES (CAST('2022-03-01' AS date), 1, 'a')
+        """
+    )
+
+    spark.sql(
+        f"""
+        INSERT INTO {catalog_name}.default.test_incremental_read
+        VALUES (CAST('2022-03-01' AS date), 2, 'b')
+        """
+    )
+
+    spark.sql(
+        f"""
+        INSERT INTO {catalog_name}.default.test_incremental_read
+        VALUES (CAST('2022-03-02' AS date), 3, 'c'), (CAST('2022-03-02' AS 
date), 4, 'b')
+        """
+    )
+
+    spark.sql(
+        f"""
+        DELETE FROM {catalog_name}.default.test_incremental_read
+        WHERE number = 2
+        """
+    )
+
+    # https://github.com/apache/iceberg/issues/1092#issuecomment-638432848 / 
https://github.com/apache/iceberg/issues/3747#issuecomment-1145419407
+    # REPLACE TABLE requires certain Hive server configuration
+    if catalog_name != "hive":
+        # Replace to break snapshot lineage:

Review Comment:
   Strictly speaking, I don't need this case because I can test broken lineage 
throwing just by inverting snapshot orders. But this feels like a realer use 
case to me. And changing the schema in this way also lets me test that the 
table's current schema is always used 😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to