smaheshwar-pltr commented on code in PR #2031:
URL: https://github.com/apache/iceberg-python/pull/2031#discussion_r2101335471
##########
pyiceberg/table/__init__.py:
##########
@@ -1092,6 +1096,61 @@ def scan(
limit=limit,
)
+ # TODO: Consider more concise name
+ def incremental_append_scan(
+ self,
+ row_filter: Union[str, BooleanExpression] = ALWAYS_TRUE,
+ selected_fields: Tuple[str, ...] = ("*",),
+ case_sensitive: bool = True,
+ from_snapshot_id: Optional[int] = None, # Exclusive
+ to_snapshot_id: Optional[int] = None, # Inclusive
+ options: Properties = EMPTY_DICT,
+ limit: Optional[int] = None,
+ ) -> IncrementalAppendScan:
+ """Fetch an IncrementalAppendScan based on the table's current
metadata.
+
+ The incremental append scan can be used to project the table's data
+ from append snapshots within a snapshot range and that matches the
+ provided row_filter onto the table's current schema
+
+ Args:
+ row_filter:
+ A string or BooleanExpression that describes the
+ desired rows
+ selected_fields:
+ A tuple of strings representing the column names
+ to return in the output dataframe.
+ case_sensitive:
+ If True column matching is case sensitive
+ from_snapshot_id:
+ Optional ID of the "from" snapshot, to start the incremental
scan from, exclusively. This can be set
+ on the IncrementalAppendScan object returned, but ultimately
must not be None.
Review Comment:
This is a change from the https://github.com/apache/iceberg-python/pull/533
to be consistent with the Java side. I do think there's an argument for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
