rdblue commented on code in PR #12598: URL: https://github.com/apache/iceberg/pull/12598#discussion_r2070451684
########## format/spec.md: ########## @@ -1761,6 +1764,10 @@ The reference Java implementation uses a type 4 uuid and XORs the 4 most signifi Java writes `-1` for "no current snapshot" with V1 and V2 tables and considers this equivalent to omitted or `null`. This has never been formalized in the spec, but for compatibility, other implementations can accept `-1` as `null`. Java will no longer write `-1` and will use `null` for "no current snapshot" for all tables with a version greater than or equal to V3. +### Legacy naming for GZIP compressed Metadata JSON files + +Some implementations have written GZIP compressed metadata JSON files with the suffix `metadata.json.gz`. The reference Java implementation will interpret files with this naming convention as GZIP files for backwards compatibility. Review Comment: I think this is the only place where filenames should be mentioned, but this note doesn't seem sufficient to me. First, we should document the behavior expected by Hadoop/FS tables that rely on a predictable file name. Second, this is where we should document that although there are no requirements for naming, the convention is encouraged to be `<unique-name>.<compression-ext>.metadata.json`. Then note that some implementations have put the compression extension at the end, like `<unique-name>.metadata.json.gz`. Update: looks like I got the proposed naming wrong and that the new convention is to put the compression suffix at the end? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
