RussellSpitzer commented on code in PR #12598:
URL: https://github.com/apache/iceberg/pull/12598#discussion_r2070480860
##########
format/spec.md:
##########
@@ -1761,6 +1764,10 @@ The reference Java implementation uses a type 4 uuid and
XORs the 4 most signifi
Java writes `-1` for "no current snapshot" with V1 and V2 tables and considers
this equivalent to omitted or `null`. This has never been formalized in the
spec, but for compatibility, other implementations can accept `-1` as `null`.
Java will no longer write `-1` and will use `null` for "no current snapshot"
for all tables with a version greater than or equal to V3.
+### Legacy naming for GZIP compressed Metadata JSON files
+
+Some implementations have written GZIP compressed metadata JSON files with the
suffix `metadata.json.gz`. The reference Java implementation will interpret
files with this naming convention as GZIP files for backwards compatibility.
Review Comment:
I think we are a bit to ambiguous here in the spec right now or at least
have not been specific in what we are leaving up to an implementation.
For example in our description of metadata tables it definitely seems like
we are mandating a postfix metadata.json. It also feels like we are specifying
other parts like the version and the random bits.
https://github.com/apache/iceberg/blob/main/format/spec.md?plain=1#L1065 ?
I'd prefer we either specifically say we think file names end in xxx or we
say that actual choice of file names is up to the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
