rdblue commented on code in PR #12598: URL: https://github.com/apache/iceberg/pull/12598#discussion_r2070444650
########## format/spec.md: ########## @@ -1473,7 +1473,10 @@ The following table describes the possible values for the some of the field with ### Table Metadata and Snapshots -Table metadata is serialized as a JSON object according to the following table. Snapshots are not serialized separately. Instead, they are stored in the table metadata JSON. +Table metadata is serialized as a JSON object according to the following table. Snapshots are not serialized separately. Instead, they are stored in the table metadata JSON. + +A metadata JSON file name must end in `.metadata.json`. A metadata JSON file may be compressed with [GZIP](https://datatracker.ietf.org/doc/html/rfc1952). A GZIP compressed file name must end with `.gz.metadata.json`. Review Comment: Why should there be any requirements for file naming, except for the FS table scheme that is deprecated? While we need to know what compression is used, it should be part of the implementation details section, not part of the spec itself. This can easily be a responsibility of the catalog or determined by file magic bytes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
