nastra commented on code in PR #12927:
URL: https://github.com/apache/iceberg/pull/12927#discussion_r2069020862


##########
core/src/main/java/org/apache/iceberg/util/JsonUtil.java:
##########
@@ -201,6 +201,14 @@ public static ByteBuffer getByteBufferOrNull(String 
property, JsonNode node) {
         
BaseEncoding.base16().decode(pNode.textValue().toUpperCase(Locale.ROOT)));
   }
 
+  public static Map<String, String> getStringMapOrNull(String property, 
JsonNode node) {

Review Comment:
   would be good to test these new methods in `TestJsonUtil`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to