RussellSpitzer commented on code in PR #12927:
URL: https://github.com/apache/iceberg/pull/12927#discussion_r2068922286
##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -195,4 +195,13 @@ default Long firstRowId() {
default Long addedRows() {
return null;
}
+
+ /**
+ * ID of the encryption key used to encrypt this snapshot's manifest list.
+ *
+ * @return a string key ID
+ */
+ default String keyId() {
Review Comment:
--didn't we call this encryptingKeyId in the spec proposal?--
NVM we have this one as key-id
##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -195,4 +195,13 @@ default Long firstRowId() {
default Long addedRows() {
return null;
}
+
+ /**
+ * ID of the encryption key used to encrypt this snapshot's manifest list.
+ *
+ * @return a string key ID
+ */
+ default String keyId() {
Review Comment:
~~didn't we call this encryptingKeyId in the spec proposal?~~
NVM we have this one as key-id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
