nastra commented on code in PR #12927:
URL: https://github.com/apache/iceberg/pull/12927#discussion_r2068395324


##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -543,6 +544,40 @@ public void applyTo(ViewMetadata.Builder 
viewMetadataBuilder) {
     }
   }
 
+  class AddEncryptionKey implements MetadataUpdate {

Review Comment:
   Related to my other comment in 
https://github.com/apache/iceberg/pull/12927/files#r2068391760 adding 
an`EncryptionKey` makes much more sense to me and semantically means that we're 
adding a key that is being used to encrypt table metadata with.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to