nastra commented on code in PR #12927:
URL: https://github.com/apache/iceberg/pull/12927#discussion_r2068377112
##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -229,6 +231,14 @@ public static void toJson(TableMetadata metadata,
JsonGenerator generator) throw
generator.writeNumberField(NEXT_ROW_ID, metadata.nextRowId());
}
+ if (metadata.keys() != null) {
Review Comment:
similar to what I mentioned in the other parser, I think it makes sense to
only write this out if `keys()` isn't empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
