hariuserx commented on PR #12886: URL: https://github.com/apache/iceberg/pull/12886#issuecomment-2829103358
> Nice @hariuserx! Now the util will preserve the null partition value. Are we seeing this happen with the other spark versions or should we backport this fix as well? Yeah. It affects both Spark 3.4 and 3.5. Do we also want to fix 3.4 in `v3.4/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java`? _Testing for 3.4:_ Copy over the new tests in 3.5 `TestAddFilesProcedure.java` to `spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java`. Build with `systemProp.defaultSparkVersions=3.4` in `gradle.properties`. The new tests fail with the same error in the desription. > should we backport this fix as well? Not sure if it important enough to backport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
