amogh-jahagirdar commented on code in PR #12886:
URL: https://github.com/apache/iceberg/pull/12886#discussion_r2078868929
##########
api/src/main/java/org/apache/iceberg/types/Conversions.java:
##########
@@ -37,7 +37,7 @@ public class Conversions {
private Conversions() {}
- private static final String HIVE_NULL = "__HIVE_DEFAULT_PARTITION__";
+ public static final String HIVE_NULL = "__HIVE_DEFAULT_PARTITION__";
Review Comment:
I'd rather not make this public and expose hive concepts for narrow use
cases through the API, I know it's a bit duplicative but could we just have a
private static constant in `Spark3Util` as well (especially considering at some
point we can move away from relying on this in the SparkPartition code, and
build actual `PartitionData` instances)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
