hariuserx commented on code in PR #12886:
URL: https://github.com/apache/iceberg/pull/12886#discussion_r2078864644
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java:
##########
@@ -946,7 +946,7 @@ public static List<SparkPartition> getPartitions(
Object catalystValue =
partition.values().get(fieldIndex, field.dataType());
Object value =
CatalystTypeConverters.convertToScala(catalystValue, field.dataType());
- values.put(field.name(), String.valueOf(value));
+ values.put(field.name(), (value == null) ? null :
value.toString());
Review Comment:
Thanks for the review. Yes, it makes sense to stick to HIVE partition
standard incase any future downstream readers decide to use the
`SparkPartition`. I have made the changes. Let me know if we want to port the
changes to 3.4 as well that Drew mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
