rdblue commented on code in PR #12736: URL: https://github.com/apache/iceberg/pull/12736#discussion_r2053126840
########## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteMergeIntoTableForRowLineage.scala: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.sql.catalyst.analysis + +import org.apache.spark.sql.catalyst.expressions.Literal +import org.apache.spark.sql.catalyst.plans.logical.Assignment +import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan +import org.apache.spark.sql.catalyst.plans.logical.MergeIntoTable +import org.apache.spark.sql.catalyst.plans.logical.UpdateAction +import org.apache.spark.sql.execution.datasources.v2.DataSourceV2Relation + +object RewriteMergeIntoTableForRowLineage extends RewriteOperationForRowLineage { + + override def apply(plan: LogicalPlan): LogicalPlan = { + plan.resolveOperators { + case m @ MergeIntoTable(_, _, _, matchedActions, _, notMatchedBySourceActions) + if m.resolved && m.rewritable && m.aligned && + (matchedActions.nonEmpty || notMatchedBySourceActions.nonEmpty) && + shouldUpdatePlan(m) => + updateMergeIntoForRowLineage(m) + } + } + + protected def updateMergeIntoForRowLineage(mergeIntoTable: MergeIntoTable): LogicalPlan = { + EliminateSubqueryAliases(mergeIntoTable.targetTable) match { + case r: DataSourceV2Relation => + val matchedActions = mergeIntoTable.matchedActions + val notMatchedBySourceActions = mergeIntoTable.notMatchedBySourceActions + val rowLineageAttributes = findRowLineageAttributes(r.metadataOutput) Review Comment: I think it would be better to return a tuple with the row ID and last updated seq attrs instead of a list. That has a couple of nice consequences. Then you wouldn't need to do the `filter` in the next couple lines. But the more important effect is that it would be more reliable because the code below that adds the attrs to the table output doesn't check the order of the attributes. It just assumes that they're in the same order as the assignments added to the actions. I don't like relying on the incoming order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
