rdblue commented on code in PR #12736:
URL: https://github.com/apache/iceberg/pull/12736#discussion_r2053112107


##########
core/src/main/java/org/apache/iceberg/TableUtil.java:
##########
@@ -60,4 +61,28 @@ public static String metadataFileLocation(Table table) {
               "%s does not have a metadata file location", 
table.getClass().getSimpleName()));
     }
   }
+
+  public static boolean supportsRowLineage(Table table) {
+    Preconditions.checkArgument(null != table, "Invalid table: null");
+    if (table instanceof BaseMetadataTable) {
+      return false;
+    }
+
+    return formatVersion(table) >= 
TableMetadata.MIN_FORMAT_VERSION_ROW_LINEAGE;
+  }
+
+  public static Schema schemaWithRowLineage(Table table) {

Review Comment:
   Should this be in `TableUtil`? It's a good util method, but it seems to fit 
better in `MetadataColumns` to me. This class just has work-arounds for things 
that aren't exposed through the `Table` API like version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to