RussellSpitzer commented on PR #12736: URL: https://github.com/apache/iceberg/pull/12736#issuecomment-2816868801
This looks good to me although I only had time to skim it today. I'll try to take a full pass later. One thing I want to make sure we test is "WHEN NOT MATCHED" with no matching clauses. Spark has some logic which transforms these from row level operations into Appends and I am a little worried some of the logic here for manipulating the output and input table will not work in that case. https://github.com/apache/iceberg/issues/12653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
