slfan1989 commented on code in PR #12783:
URL: https://github.com/apache/iceberg/pull/12783#discussion_r2047173652
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/SnapshotTableProcedure.java:
##########
@@ -104,8 +106,8 @@ public InternalRow[] call(InternalRow args) {
action.tableLocation(snapshotLocation);
}
- if (!args.isNullAt(4)) {
- int parallelism = args.getInt(4);
+ Integer parallelism = input.asInt(PARALLELISM_PARAM, null);
+ if (parallelism != null) {
Review Comment:
Can I modify it to the following this?
```
Preconditions.checkArgument(parallelism == null || parallelism > 0,
"Parallelism should be larger than 0");
if (parallelism != null) {
action = action.executeWith(SparkTableUtil.migrationService(parallelism));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
