slfan1989 commented on code in PR #12783:
URL: https://github.com/apache/iceberg/pull/12783#discussion_r2047058500
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/SnapshotTableProcedure.java:
##########
@@ -104,11 +106,9 @@ public InternalRow[] call(InternalRow args) {
action.tableLocation(snapshotLocation);
}
- if (!args.isNullAt(4)) {
- int parallelism = args.getInt(4);
- Preconditions.checkArgument(parallelism > 0, "Parallelism should be
larger than 0");
- action =
action.executeWith(SparkTableUtil.migrationService(parallelism));
- }
+ int parallelism = input.asInt(PARALLELISM_PARAM, 1);
Review Comment:
Thank you for reviewing the code! I've made the changes based on your
suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
