manuzhang commented on code in PR #12783:
URL: https://github.com/apache/iceberg/pull/12783#discussion_r2045934050


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/SnapshotTableProcedure.java:
##########
@@ -104,11 +106,9 @@ public InternalRow[] call(InternalRow args) {
       action.tableLocation(snapshotLocation);
     }
 
-    if (!args.isNullAt(4)) {
-      int parallelism = args.getInt(4);
-      Preconditions.checkArgument(parallelism > 0, "Parallelism should be 
larger than 0");
-      action = 
action.executeWith(SparkTableUtil.migrationService(parallelism));
-    }
+    int parallelism = input.asInt(PARALLELISM_PARAM, 1);

Review Comment:
   Please do not change the previous default value, `null`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to