manuzhang commented on code in PR #12783:
URL: https://github.com/apache/iceberg/pull/12783#discussion_r2047089181
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/SnapshotTableProcedure.java:
##########
@@ -104,8 +106,8 @@ public InternalRow[] call(InternalRow args) {
action.tableLocation(snapshotLocation);
}
- if (!args.isNullAt(4)) {
- int parallelism = args.getInt(4);
+ Integer parallelism = input.asInt(PARALLELISM_PARAM, null);
+ if (parallelism != null) {
Review Comment:
This can be simplified into `Preconditions.checkArgument(parallelism == null
|| parallelism > 0, "Parallelism should be larger than 0");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
