wypoon commented on code in PR #12721:
URL: https://github.com/apache/iceberg/pull/12721#discussion_r2040220260
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java:
##########
@@ -303,10 +303,10 @@ public void testThriftExceptionConcurrentCommit() throws
TException, Interrupted
@Test
public void testInvalidObjectException() {
- TableIdentifier badTi = TableIdentifier.of(DB_NAME, "`tbl`");
+ TableIdentifier badTi = TableIdentifier.of(DB_NAME, "tábl");
Review Comment:
This is explained in https://github.com/apache/iceberg/pull/12681 as well.
Before Hive 4, the only special character allowed is '/' (so the backtick,
'`' is not allowed in the name), but in Hive 4, other special characters,
including backtick, are allowed, so for the purpose of an invalid name, I have
changed the name used for this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
