rodmeneses commented on code in PR #12745:
URL: https://github.com/apache/iceberg/pull/12745#discussion_r2038215304
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergCommitter.java:
##########
@@ -706,51 +706,6 @@ public void
testRecoveryFromSnapshotWithoutCompletedNotification() throws Except
SimpleDataUtil.assertTableRows(table, expectedRows, branch);
assertSnapshotSize(1);
-
- assertMaxCommittedCheckpointId(jobId, operatorId.toString(), 0);
-
- RowData row = SimpleDataUtil.createRowData(2, "world");
- expectedRows.add(row);
- DataFile dataFile = writeDataFile("data-2", ImmutableList.of(row));
- processElement(jobId, checkpointId, harness, 1, operatorId.toString(),
dataFile);
-
- snapshot = harness.snapshot(++checkpointId, ++timestamp);
- assertFlinkManifests(0);
Review Comment:
Hi @pvary. Thanks for your comment!
It is hard to tell. Given that the `IcebergSink` hasn't changed itself, it
seems to be related to code change in the flink upgrade to 1.19.2 and 1.20.1
https://issues.apache.org/jira/browse/FLINK-36455
@mxm Did you get similar error while working on the 2.0 flink integration
with iceberg?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
