rodmeneses commented on code in PR #12745:
URL: https://github.com/apache/iceberg/pull/12745#discussion_r2033421593
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergCommitter.java:
##########
@@ -706,51 +706,6 @@ public void
testRecoveryFromSnapshotWithoutCompletedNotification() throws Except
SimpleDataUtil.assertTableRows(table, expectedRows, branch);
assertSnapshotSize(1);
-
- assertMaxCommittedCheckpointId(jobId, operatorId.toString(), 0);
-
- RowData row = SimpleDataUtil.createRowData(2, "world");
- expectedRows.add(row);
- DataFile dataFile = writeDataFile("data-2", ImmutableList.of(row));
- processElement(jobId, checkpointId, harness, 1, operatorId.toString(),
dataFile);
-
- snapshot = harness.snapshot(++checkpointId, ++timestamp);
- assertFlinkManifests(0);
- }
-
- // Redeploying flink job from external checkpoint.
- JobID newJobId = new JobID();
- try (OneInputStreamOperatorTestHarness<
- CommittableMessage<IcebergCommittable>,
CommittableMessage<IcebergCommittable>>
- harness = getTestHarness()) {
- harness.getStreamConfig().setOperatorID(operatorId);
- harness.initializeState(snapshot);
Review Comment:
Hi @mxm . Thanks for your review!
Given that the test name is
testRecoveryFromSnapshot**WithoutCompletedNotification**, in my opinion,
explicitly calling `harness.notifyCheckpointComplete` should be avoided as that
is exactly what the unit test is trying to assert: that we are able to recover
from snapshot without explicitly triggering the commit.
Also, please note that the first part of the unit test, is already asserting
that `harness.initializeState` is actually triggering the pending commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
