rodmeneses opened a new pull request, #12745: URL: https://github.com/apache/iceberg/pull/12745
This code also updates `testRecoveryFromSnapshotWithoutCompletedNotification` unit test, by removing the second assertion when we check that `harness.initializeState` is actually committing pending transactions. The reason we need to remove it, is because the flink test harness has a known limitation, where for recovery the lastCompleted checkpoint is always reset to 0, which makes it impossible to correctly commit the pending commits when the checkpointId > 0. see: https://issues.apache.org/jira/browse/FLINK-36058 and: https://github.com/apache/flink/blob/master/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperatorTestBase.java#L184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
