pvary commented on code in PR #12721:
URL: https://github.com/apache/iceberg/pull/12721#discussion_r2034778699
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -104,12 +103,12 @@ public void initialize(String inputName, Map<String,
String> properties) {
}
if (properties.containsKey(CatalogProperties.URI)) {
- this.conf.set(HiveConf.ConfVars.METASTOREURIS.varname,
properties.get(CatalogProperties.URI));
+ this.conf.set("hive.metastore.uris",
properties.get(CatalogProperties.URI));
Review Comment:
On the other PR
(https://github.com/apache/iceberg/pull/12681#discussion_r2030387861)
@manuzhang mentioned that we might want to create constants for the keys.
While I agree with you that we don't want to expose the constants for the
users (they just should use the Hive ones), we might want to create
`@VisibleForTesting` package private constants to get rid of the strings all
over the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
