pvary commented on code in PR #12721:
URL: https://github.com/apache/iceberg/pull/12721#discussion_r2034797879
##########
build.gradle:
##########
@@ -763,6 +763,167 @@ project(':iceberg-hive-metastore') {
}
}
+project(':iceberg-hive3-metastore') {
Review Comment:
I'm really interested in what others think about this.
This one is very much inline how we handle different versions of engines
today, however it seems to me that we generating too much code for a different
purpose.
`iceberg-hive-metastore` is more like an infrastructure for me, and having a
matrix of (hive2-Spark3.4, hive2-Spark3.5, hive3-Spark3.4, etc.) seems like an
overkill for me.
What if:
```
List<String> knownHiveVersions =
System.getProperty("knownHiveVersions").split(",")
String hiveVersion = System.getProperty("hiveVersion") != null ?
System.getProperty("hiveVersion") : System.getProperty("defaultHiveVersion")
if (!knownHiveVersions.contains(hiveVersion)) {
throw new GradleException("Found unsupported Hive version: " + hiveVersion)
}
```
And then use `hiveVersion` to manage the dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
