wypoon commented on code in PR #12721:
URL: https://github.com/apache/iceberg/pull/12721#discussion_r2035522822
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -104,12 +103,12 @@ public void initialize(String inputName, Map<String,
String> properties) {
}
if (properties.containsKey(CatalogProperties.URI)) {
- this.conf.set(HiveConf.ConfVars.METASTOREURIS.varname,
properties.get(CatalogProperties.URI));
+ this.conf.set("hive.metastore.uris",
properties.get(CatalogProperties.URI));
Review Comment:
Peter, package private constants will not be accessible in the Flink and
Spark modules that also need to access the Hive conf (mostly in test code, but
also in `SparkSessionCatalog`). See
https://github.com/apache/iceberg/pull/12693.
I don't think this is worthwhile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
