pvary commented on code in PR #12721:
URL: https://github.com/apache/iceberg/pull/12721#discussion_r2032951407
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java:
##########
@@ -186,9 +189,9 @@ public void stop() throws Exception {
if (executorService != null) {
executorService.shutdown();
}
- if (baseHandler != null) {
- baseHandler.shutdown();
- }
+ // if (baseHandler != null) {
+ // baseHandler.shutdown();
+ // }
Review Comment:
I thought that I have answered this, if so, sorry for the double post.
I'm concerned a bit because of the following:
```
if (baseHandler instanceof FacebookBase) {
base = (FacebookBase) baseHandler;
}
[..]
if (base != null) {
base.shutdown();
}
```
This would mean that if for whatever reason the `baseHandler` changes type,
we silently skip calling shutdown, and it might cause issues later. Maybe we
just should skip the `instanceof` check?
> HMSHandler extends FacebookBase and implements IHMSHandler, but
FacebookBase and IHMSHandler do not have a common parent interface.
(FacebookService.Iface is not such an interface.)
I'm not entirely sure I understand your reasoning. Isn't `FacebookBase`
implements `FacebookService.Iface`. Couldn't we just rely on the base interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
