adutra commented on code in PR #12612:
URL: https://github.com/apache/iceberg/pull/12612#discussion_r2013575429


##########
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##########
@@ -95,7 +98,7 @@ private RESTClient httpClient() {
   private LoadCredentialsResponse fetchCredentials() {
     return httpClient()
         .get(
-            properties.get(URI),
+            properties.get(CREDENTIALS_ENDPOINT),

Review Comment:
   Right, but my point was: why bother absolutizing 
`refreshCredentialsEndpoint` in `AwsClientProperties`? The HTTP client could 
handle that internally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to