nastra commented on code in PR #12612:
URL: https://github.com/apache/iceberg/pull/12612#discussion_r2013463584
##########
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##########
@@ -95,7 +98,7 @@ private RESTClient httpClient() {
private LoadCredentialsResponse fetchCredentials() {
return httpClient()
.get(
- properties.get(URI),
+ properties.get(CREDENTIALS_ENDPOINT),
Review Comment:
see my other comment above. we don't need two properties as we can just pass
the catalog URI via
```
Optional.ofNullable(allProperties.get(allProperties.get(CatalogProperties.URI)))
.ifPresent(
catalogUri ->
clientCredentialsProviderProperties.put(CatalogProperties.URI, catalogUri));
```
The absolute/relative path handling is already done in
https://github.com/apache/iceberg/blob/7d0395d4b6f8d690d70910fe2018a459582960e3/aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java#L109-L111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
