danielcweeks commented on code in PR #12612:
URL: https://github.com/apache/iceberg/pull/12612#discussion_r2017693094
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestVendedCredentialsProvider.java:
##########
@@ -48,7 +49,12 @@
public class TestVendedCredentialsProvider {
private static final int PORT = 3232;
- private static final String URI =
String.format("http://127.0.0.1:%d/v1/credentials";, PORT);
+ private static final String CREDENTIALS_URI =
+ String.format("http://127.0.0.1:%d/v1/credentials";, PORT);
Review Comment:
Technically you can point to an URI, but I think we need to include a test
pointing to a path consistent with the spec (e.g.
`/v1/{prefix}/namespaces/{namespace}/tables/{table}/credentials`) and we should
test both absolute and relative (which I believe this change will address as
well.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
