nastra commented on code in PR #12612:
URL: https://github.com/apache/iceberg/pull/12612#discussion_r2011474250
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -199,7 +199,9 @@ public AwsCredentialsProvider credentialsProvider(
String accessKeyId, String secretAccessKey, String sessionToken) {
if (refreshCredentialsEnabled &&
!Strings.isNullOrEmpty(refreshCredentialsEndpoint)) {
clientCredentialsProviderProperties.put(
- VendedCredentialsProvider.URI, refreshCredentialsEndpoint);
+ VendedCredentialsProvider.CREDENTIALS_ENDPOINT,
refreshCredentialsEndpoint);
+ clientCredentialsProviderProperties.put(
+ VendedCredentialsProvider.URI,
allProperties.get(CatalogProperties.URI));
Review Comment:
rather than introducing/renaming the existing property, we could just do
```
Optional.ofNullable(allProperties.get(allProperties.get(CatalogProperties.URI)))
.ifPresent(
catalogUri ->
clientCredentialsProviderProperties.put(CatalogProperties.URI, catalogUri));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
