lirui-apache commented on PR #12637: URL: https://github.com/apache/iceberg/pull/12637#issuecomment-2750270432
I need to make these changes to enable a test with NoLock: 1. Allow direct SQL in test metastore, because the transactional altering table now relies on direct SQL as of [HIVE-28121](https://issues.apache.org/jira/browse/HIVE-28121) 2. Change the type of `TABLE_PARAMS.PARAM_VALUE` from `CLOB` to `VARCHAR(32672)`. This is because derby doesn't allow comparing clob type with a string, so the direct SQL will fail. I believe tests in Hive can run because Hive initializes the underlying DB with the [JDO mapping](https://github.com/apache/hive/blob/rel/release-2.3.10/metastore/src/model/package.jdo#L173) instead of the metastore SQL script. If these changes turn out to be unacceptable, I suppose we can just mock the exception in the HMS client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
