rdblue commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r2008311859
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +565,134 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
+ if (crs != null) {
+ Preconditions.checkArgument(!crs.isEmpty(), "Invalid CRS: (empty
string)");
+ Preconditions.checkArgument(
Review Comment:
I don't think this check is needed. We don't do similar validations
elsewhere. The responsibility of this class is to pass the incoming CRS without
modification. There's no need to validate the string. Parsing should handle
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
