Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r2004547525
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +561,120 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
+ this.crs = crs;
Review Comment:
Geography does not always show the default CRS. It happens when the edge
algorithm is not using default value but CRS is left unset. We have to fill in
the default CRS as the first argument in this case.
I thought that the behavior of toString is to omit optional parameters when
possible. See
https://github.com/apache/iceberg/pull/12346/files/0c451cac53f4098680aa0ae518af70dc45efaeb1#r1994430054.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
